fix(page-nav): hold min-height:0 on scrolling middle and shrink-no on Direct bottom rows so flex pressure no longer squashes them below their NavItem floor
This commit is contained in:
parent
3c7c79fb6c
commit
c3a384b651
3 changed files with 8 additions and 1 deletions
|
|
@ -384,7 +384,12 @@ export function PageNavContent({
|
||||||
scrollRef?: MutableRefObject<HTMLDivElement | null>;
|
scrollRef?: MutableRefObject<HTMLDivElement | null>;
|
||||||
}) {
|
}) {
|
||||||
return (
|
return (
|
||||||
<Box grow="Yes" direction="Column">
|
// `minHeight: 0` is the canonical flexbox fix for a scroll child inside
|
||||||
|
// a flex column: without it the Scroll's intrinsic content height pushes
|
||||||
|
// the wrapper to that height, the column overflows the viewport, and
|
||||||
|
// every sibling with default `flex-shrink: 1` (header / footer rows)
|
||||||
|
// gets squashed below its natural height.
|
||||||
|
<Box grow="Yes" direction="Column" style={{ minHeight: 0 }}>
|
||||||
<Scroll
|
<Scroll
|
||||||
ref={scrollRef}
|
ref={scrollRef}
|
||||||
variant="Background"
|
variant="Background"
|
||||||
|
|
|
||||||
|
|
@ -15,6 +15,7 @@ export function DirectNewChatRow() {
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Box
|
<Box
|
||||||
|
shrink="No"
|
||||||
style={{
|
style={{
|
||||||
padding: `${toRem(6)} ${config.space.S100}`,
|
padding: `${toRem(6)} ${config.space.S100}`,
|
||||||
borderTop: `${config.borderWidth.B300} solid ${color.Surface.ContainerLine}`,
|
borderTop: `${config.borderWidth.B300} solid ${color.Surface.ContainerLine}`,
|
||||||
|
|
|
||||||
|
|
@ -57,6 +57,7 @@ export function DirectSelfRow() {
|
||||||
// free to fire when there's no movement (tap → openSheet).
|
// free to fire when there's no movement (tap → openSheet).
|
||||||
return (
|
return (
|
||||||
<Box
|
<Box
|
||||||
|
shrink="No"
|
||||||
{...{ [SETTINGS_SHEET_DRAG_ORIGIN_ATTR]: true }}
|
{...{ [SETTINGS_SHEET_DRAG_ORIGIN_ATTR]: true }}
|
||||||
style={{
|
style={{
|
||||||
padding: `${toRem(6)} ${config.space.S100}`,
|
padding: `${toRem(6)} ${config.space.S100}`,
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue