Repair a catalogue entry that pinned the wrong thing: the screen's version needs both edits to reproduce, and the tool's own comment stops promising a gap it does not cover
This commit is contained in:
parent
260a625396
commit
2e13cd1aca
2 changed files with 14 additions and 2 deletions
|
|
@ -374,7 +374,14 @@ func one(root string, m Mutation, timeout time.Duration, logs string) (v verdict
|
|||
path := filepath.Join(root, file)
|
||||
body, rerr := os.ReadFile(path)
|
||||
if rerr != nil {
|
||||
return survivedTests, "", fmt.Errorf("%s: %w", m.ID, rerr)
|
||||
// ROT, not a run failure. ⚠ AND IT DOES NOT CLOSE THE MOVED-FILE CASE, which is what a first
|
||||
// draft of this comment claimed: the fingerprint pass above reads every file the catalogue names
|
||||
// BEFORE any entry runs, so a renamed or deleted file still aborts the whole run there, ahead of
|
||||
// this line. Measured: a catalogue with one entry naming a missing file printed
|
||||
// «fingerprint …: no such file or directory» and ran nothing, the healthy entry behind it
|
||||
// included. What this branch does cover is the narrow race — a file that disappears BETWEEN the
|
||||
// fingerprint pass and this read. The moved-file abort is a live gap with a backlog row.
|
||||
return rotted, fmt.Sprintf("%s: %v (the file moved or was deleted under the catalogue)", m.ID, rerr), nil
|
||||
}
|
||||
mu.Lock()
|
||||
saved = append(saved, original{path: path, body: body, sum: hash(body)})
|
||||
|
|
|
|||
|
|
@ -1576,9 +1576,14 @@
|
|||
},
|
||||
{
|
||||
"id": "WB36-langscreen-version-literal",
|
||||
"why": "the screen's version must be DERIVED from its calibrated constants: a literal lets the floor slide with no snapshot move, and a resumed chunk is re-verdicted by a rule nobody re-billed for",
|
||||
"why": "the screen's version must be DERIVED from its constants. ⚠ TWO edits, and both are the entry: the literal ALONE is harmless (it prints what the derivation prints) and the slide alone moves the derived string honestly. Only together do they reproduce the finding — the floor slides 0.50→0.45 while the version stays byte-identical, so a resumed chunk is re-verdicted under a threshold nobody re-billed for. An earlier version of this entry carried the SLIDE ONLY under this name, and passed for a pin it was not: it reddened the boundary fixture, never the derivation",
|
||||
"package": "./internal/langscreen/",
|
||||
"edits": [
|
||||
{
|
||||
"file": "internal/langscreen/langscreen.go",
|
||||
"find": "var Version = fmt.Sprintf(\"langscreen-v1-target-script-share+floor%.2f+min%d\", OnTargetFloor, MinLetters)",
|
||||
"replace": "var Version = fmt.Sprint(\"langscreen-v1-target-script-share+floor0.50+min200\")"
|
||||
},
|
||||
{
|
||||
"file": "internal/langscreen/langscreen.go",
|
||||
"find": "const OnTargetFloor = 0.50",
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue